feat(analyzer): add generic VIN and IMEI recognizers by thatomokoena · Pull Request #2070 · data-privacy-stack/presidio

thatomokoena · 2026-06-17T14:02:09Z

Change Description

Adds generic VinRecognizer for VIN (17-character ISO 3779 vehicle identifiers) with pattern matching, context words, and North American mod-11 check-digit validation. Valid check digits boost confidence to MAX_SCORE for any region; invalid check digits are rejected for North American WMIs (prefix 1-5); non-NA mismatches keep the base pattern score.
Adds generic ImeiRecognizer for IMEI (15-digit mobile device identifiers) with a formatted pattern (##-######-######-#), context words, and Luhn checksum invalidation. Bare 15-digit matching is omitted to avoid collisions with other Luhn identifiers such as AMEX credit card numbers.
Registers both recognizers in default_recognizers.yaml (enabled by default), exports them from predefined_recognizers, and documents them in supported_entities.md and CHANGELOG.md.
Adds test_vin_recognizer.py and test_imei_recognizer.py; all pass locally. ruff check passes on new recognizer source files.

Issue reference

N/A

Checklist

I have reviewed the contribution guidelines
I have signed the CLA (if required)
My code includes unit tests
All unit tests and lint checks pass locally
My PR contains documentation updates / additions if required

Add VinRecognizer and ImeiRecognizer as enabled predefined recognizers with pattern matching, context support, and checksum validation for vehicle and mobile device identifiers. Co-authored-by: Cursor <cursoragent@cursor.com>

thatomokoena · 2026-06-17T14:04:05Z

@microsoft-github-policy-service agree

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds two new generic predefined recognizers (VIN and IMEI) to Presidio Analyzer and wires them into the default registry/config, along with tests and documentation updates.

Changes:

Introduces VinRecognizer with a VIN regex plus check-digit validation logic.
Introduces ImeiRecognizer with IMEI regex patterns plus Luhn checksum invalidation.
Registers both recognizers in package exports, default YAML config, supported entities docs, and changelog.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
presidio-analyzer/presidio_analyzer/predefined_recognizers/generic/vin_recognizer.py	New VIN recognizer implementation with mod-11 check digit logic
presidio-analyzer/presidio_analyzer/predefined_recognizers/generic/imei_recognizer.py	New IMEI recognizer implementation with Luhn validation
presidio-analyzer/presidio_analyzer/predefined_recognizers/generic/init.py	Exposes new recognizers from the `generic` package
presidio-analyzer/presidio_analyzer/predefined_recognizers/init.py	Exposes new recognizers at the top-level predefined module
presidio-analyzer/presidio_analyzer/conf/default_recognizers.yaml	Enables loading the new recognizers by default
presidio-analyzer/tests/test_vin_recognizer.py	Adds unit tests for VIN detection and validation behavior
presidio-analyzer/tests/test_imei_recognizer.py	Adds unit tests for IMEI detection and invalidation behavior
docs/supported_entities.md	Documents newly supported IMEI and VIN entities
CHANGELOG.md	Records the addition of VIN and IMEI recognizers

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Reject invalid North American VIN check digits for WMI prefixes 1-5 while preserving base scores for non-NA VINs. Remove bare 15-digit IMEI pattern to avoid collisions with AMEX and other Luhn identifiers. Co-authored-by: Cursor <cursoragent@cursor.com>

Wire sanitize_value through invalidate_result so custom separator replacement_pairs are honored, matching other pattern recognizers. Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Align IMEI Luhn description and VIN validate_result return docs with actual behavior per Copilot review feedback. Co-authored-by: Cursor <cursoragent@cursor.com>

thatoisnaked · 2026-06-18T07:50:25Z

Hi @SharonHart @omri374. When you have time, would you be willing to take a look at this PR for adding IMEI and VIN recognizers? Happy to address any feedback. Thanks!

Reflect two new enabled predefined recognizers in the registry test assertion. Co-authored-by: Cursor <cursoragent@cursor.com>

thatomokoena · 2026-06-18T12:36:57Z

Hi @SharonHart. The CI failure on PR #2070 is fixed.

The Test Analyzer job was failing because test_recognizer_registry.py still expected 28 enabled predefined recognizers; adding VinRecognizer and ImeiRecognizer bumped the count to 30. I updated the assertion accordingly and pushed commit b3086be (test(analyzer): update recognizer registry count for VIN and IMEI). The registry, VIN, and IMEI tests all pass locally.

CI should be green on the next run. When you have a moment, could you take another look? Thanks!

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

…rivacy-stack#2070 Document space-delimited IMEI formats in the changelog and add ImeiRecognizer and VinRecognizer to PREDEFINED_RECOGNIZERS so default engine tests cover the new recognizers. Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

omri374

Thanks and apologies for the late review! Left a couple of comments. Happy to hear your thoughts on the VIM logic and its robustness

Port data-privacy-stack/presidio#2070 (still open upstream) to the fork. - IMEI: 15-digit device id, Luhn-validated (promote to 1.0). Upstream regex uses a backreference; rewritten loose since the validator strips separators. - VIN: 17-char ISO 3779 id (excludes I/O/Q), mod-11 check digit. North-American VINs (WMI 1-5) with a bad check digit are rejected; elsewhere a bad digit keeps the base score (many real non-NA VINs lack a valid check digit). Both wired into all_english(); unit + end-to-end tests added. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Bring branch up to date with upstream/main (26 commits), resolving conflicts to keep VIN/IMEI recognizers alongside UUID and other main additions. Co-authored-by: Cursor <cursoragent@cursor.com>

VIN bare-pattern matching risks false positives outside NA check-digit enforcement, so load it disabled like other checksum recognizers. Strengthen VIN tests with exact MAX scores, an order-ID negative case, and context enhancement coverage. Co-authored-by: Cursor <cursoragent@cursor.com>

Break the class docstring across lines so ruff check stays within the 88-character limit enforced by CI. Co-authored-by: Cursor <cursoragent@cursor.com>

thatomokoena · 2026-07-29T07:40:09Z

@omri374 Thanks for the review. I've disabled VinRecognizer by default (enabled: false) and kept ImeiRecognizer enabled. VIN tests now assert exact MAX for verified NA VINs, include an order-ID negative case, and cover context score enhancement. Happy to discuss the VIN validation approach if useful. Sorry for the delayed response - things go a bit busy.

feat(analyzer): add generic VIN and IMEI recognizers

fd53dc8

Add VinRecognizer and ImeiRecognizer as enabled predefined recognizers with pattern matching, context support, and checksum validation for vehicle and mobile device identifiers. Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot AI review requested due to automatic review settings June 17, 2026 14:02

github-actions Bot added the external label Jun 17, 2026

Copilot AI reviewed Jun 17, 2026

View reviewed changes

Comment thread presidio-analyzer/presidio_analyzer/predefined_recognizers/generic/vin_recognizer.py

Comment thread presidio-analyzer/presidio_analyzer/predefined_recognizers/generic/imei_recognizer.py

thatomokoena added 2 commits June 18, 2026 08:15

Merge branch 'main' into feature/generic-vin-imei-recognizers

b0ddf80

Merge branch 'main' into feature/generic-vin-imei-recognizers

7b9f290

Copilot AI review requested due to automatic review settings June 18, 2026 06:22

Copilot started reviewing on behalf of thatomokoena June 18, 2026 06:23 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

Comment thread presidio-analyzer/presidio_analyzer/predefined_recognizers/generic/imei_recognizer.py Outdated

Comment thread presidio-analyzer/presidio_analyzer/predefined_recognizers/generic/vin_recognizer.py Outdated

thatomokoena and others added 2 commits June 18, 2026 08:39

fix(analyzer): use replacement_pairs in ImeiRecognizer validation

d68f04c

Wire sanitize_value through invalidate_result so custom separator replacement_pairs are honored, matching other pattern recognizers. Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot AI review requested due to automatic review settings June 18, 2026 06:44

Copilot started reviewing on behalf of thatomokoena June 18, 2026 06:45 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

docs(analyzer): clarify VIN and IMEI recognizer docstrings

9b32f4e

Align IMEI Luhn description and VIN validate_result return docs with actual behavior per Copilot review feedback. Co-authored-by: Cursor <cursoragent@cursor.com>

test(analyzer): update recognizer registry count for VIN and IMEI

b3086be

Reflect two new enabled predefined recognizers in the registry test assertion. Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot AI review requested due to automatic review settings June 18, 2026 12:32

Copilot started reviewing on behalf of thatomokoena June 18, 2026 12:34 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

Comment thread presidio-analyzer/presidio_analyzer/predefined_recognizers/generic/imei_recognizer.py Outdated

Comment thread CHANGELOG.md Outdated

update doc string to match regex implementation

79ec215

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 18, 2026 13:27

Copilot started reviewing on behalf of thatomokoena June 18, 2026 13:28 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

Comment thread presidio-analyzer/presidio_analyzer/predefined_recognizers/__init__.py

thatomokoena and others added 2 commits June 18, 2026 15:38

Merge branch 'main' into feature/generic-vin-imei-recognizers

d3556de

Copilot AI review requested due to automatic review settings June 22, 2026 06:36

Copilot started reviewing on behalf of thatomokoena June 22, 2026 06:36 View session

Copilot AI reviewed Jun 22, 2026

View reviewed changes

Comment thread docs/supported_entities.md

Comment thread presidio-analyzer/tests/test_vin_recognizer.py Outdated

Comment thread presidio-analyzer/tests/test_vin_recognizer.py Outdated

omri374 reviewed Jul 12, 2026

View reviewed changes

Comment thread presidio-analyzer/presidio_analyzer/conf/default_recognizers.yaml

Comment thread presidio-analyzer/tests/test_vin_recognizer.py Outdated

Merge branch 'main' into feature/generic-vin-imei-recognizers

701945b

thatomokoena and others added 3 commits July 28, 2026 14:52

Merge branch 'main' into feature/generic-vin-imei-recognizers

78cc970

Bring branch up to date with upstream/main (26 commits), resolving conflicts to keep VIN/IMEI recognizers alongside UUID and other main additions. Co-authored-by: Cursor <cursoragent@cursor.com>

fix(analyzer): wrap IMEI recognizer docstring for ruff E501

9996c03

Break the class docstring across lines so ruff check stays within the 88-character limit enforced by CI. Co-authored-by: Cursor <cursoragent@cursor.com>

thatomokoena requested a review from omri374 July 29, 2026 07:41

Uh oh!

Conversation

thatomokoena commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change Description

Issue reference

Checklist

Uh oh!

thatomokoena commented Jun 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thatoisnaked commented Jun 18, 2026

Uh oh!

thatomokoena commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

omri374 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thatomokoena commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thatomokoena commented Jun 17, 2026 •

edited

Loading

thatomokoena commented Jun 18, 2026 •

edited

Loading

thatomokoena commented Jul 29, 2026 •

edited

Loading